Enable metric collection from MetricReader#1241
Merged
lalitb merged 19 commits intoopen-telemetry:mainfrom Mar 18, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
- Coverage 92.37% 91.99% -0.38%
==========================================
Files 203 205 +2
Lines 7338 7395 +57
==========================================
+ Hits 6778 6802 +24
- Misses 560 593 +33
|
…p into metric-collector
esigo
reviewed
Mar 4, 2022
esigo
reviewed
Mar 13, 2022
esigo
reviewed
Mar 13, 2022
esigo
reviewed
Mar 13, 2022
esigo
reviewed
Mar 13, 2022
esigo
reviewed
Mar 13, 2022
esigo
reviewed
Mar 13, 2022
esigo
reviewed
Mar 13, 2022
3 tasks
ThomsonTan
reviewed
Mar 14, 2022
DebajitDas
pushed a commit
to DebajitDas/opentelemetry-cpp
that referenced
this pull request
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1091
Changes
This PR enables MetricReader to invoke metric collection. The flow is drawn (with red) in block diagram.
Flow
MetricReader::Collect() -> MetricCollector::Collect() -> Meter::Collect() -> AggregationStorage::Collect()
MetricReader and CollectorHandle are base classes for MetricCollector and are meant to be opaque handles over MetricCollector.
CHANGELOG.mdupdated for non-trivial changes