Remove nostd::span as dependency from Dependency document#1260
Merged
lalitb merged 5 commits intoopen-telemetry:mainfrom Mar 13, 2022
Merged
Remove nostd::span as dependency from Dependency document#1260lalitb merged 5 commits intoopen-telemetry:mainfrom
lalitb merged 5 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1260 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 202 202
Lines 7336 7336
=======================================
Hits 6776 6776
Misses 560 560 |
esigo
approved these changes
Mar 12, 2022
DebajitDas
pushed a commit
to DebajitDas/opentelemetry-cpp
that referenced
this pull request
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1230
Changes
Have validated the two components nostd::span and std::variant. None of these have been copied ( read - lift and shift) directly from the libstd implementation. They have been written to ensure that the ABI compatibility is maintained with libstdc++. The code has been compared with libstd library here and here, and also confirmed with the contributor of std::variant in this repo.
The dependency document has been updated to remove
nostd::spanas internal dependency.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes