Implement basic OTLP Recordable#127
Merged
reyang merged 26 commits intoJul 2, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 71 71
Lines 1724 1724
=======================================
Hits 1612 1612
Misses 112 112 |
Contributor
Author
|
I signed my CLA. |
g-easy
reviewed
Jun 25, 2020
|
LGTM :) |
IlyaKobelevskiy
approved these changes
Jun 26, 2020
pyohannes
reviewed
Jun 26, 2020
Contributor
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
This looks good to me, I only have one request about a missing CMake integration.
Contributor
Author
|
@pyohannes I've updated my code to address your comment, please let me know if there's anything else! |
Contributor
Author
|
@reyang This branch is ready to merge! |
Closed
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
…s-create-or-update-comment-digest Update peter-evans/create-or-update-comment digest to 861c151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added and implemented
SetIds(),SetStartTime()andSetDuration()for the OTLP Recordable. These functions should be enough to create minimal spans that can be sent to the OpenTelemetry Collector. Also added unit tests for the Recordable.