Skip to content

Disable benchmark action failure #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esigo merged 2 commits into from
Mar 24, 2022
Merged

Disable benchmark action failure #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
744a68d
disable benchmark action failure
esigo Mar 23, 2022
0efea28
disable fail on alert
esigo Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ jobs:
# Show alert with commit comment on detecting possible performance regression
alert-threshold: '200%'
comment-on-alert: true
fail-on-alert: true
fail-on-alert: false
Copy link
Copy Markdown
Contributor

@ThomsonTan ThomsonTan Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With fail-on-alert set to false, will we still get notified with regression, or we need to visit the benchmark page to get the result?

Copy link
Copy Markdown
Member Author

@esigo esigo Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow will not be marked as failed but still there will be some comment on the commits as we have now.

gh-pages-branch: gh-pages
benchmark-data-dir-path: benchmarks
2 changes: 1 addition & 1 deletion docs/performance/benchmarks.rst → docs/public/performance/benchmarks.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ Performance Tests - Benchmarks

Click `here <https://open-telemetry.github.io/opentelemetry-cpp/benchmarks/index.html>`_ to view the latest performance benchmarks for packages in this repo.

Please note that the flutation in the results are mainly because [machines with different CPUs](https://github.com/benchmark-action/github-action-benchmark/issues/79) are used for tests.
Please note that the flutation in the results are mainly because `machines with different CPUs <https://github.com/benchmark-action/github-action-benchmark/issues/79>`_ are used for tests.