Skip to content

Context Propagation Update: Headers#129

Closed
Tianlin-Zhao wants to merge 15 commits into
open-telemetry:masterfrom
ZhaoTianlin990121:origin/release
Closed

Context Propagation Update: Headers#129
Tianlin-Zhao wants to merge 15 commits into
open-telemetry:masterfrom
ZhaoTianlin990121:origin/release

Conversation

@Tianlin-Zhao
Copy link
Copy Markdown
Contributor

This branch contains the header file for httptextformat, an interface.

@Tianlin-Zhao Tianlin-Zhao requested a review from a team June 25, 2020 20:52
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jun 25, 2020

CLA Check

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 25, 2020

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          66       66           
  Lines        1656     1656           
=======================================
  Hits         1545     1545           
  Misses        111      111           

@Tianlin-Zhao
Copy link
Copy Markdown
Contributor Author

There's a Bazel-related error:
ERROR:The project you're trying to build requires Bazel 3.2.0 (specified in /Users/runner/runners/2.263.0/work/opentelemetry-cpp/opentelemetry-cpp/.bazelversion), but it wasn't found in /usr/local/Cellar/bazel/3.3.0/libexec/bin.
I don't know if that's my coding's issue or just the setup of my laptop's.

@Tianlin-Zhao
Copy link
Copy Markdown
Contributor Author

Also, there's a problem with span: there's a span.h under nostd folder and a span.h under trace folder. I am not sure which one I am supposed to be following with to define my functions.

@nadiaciobanu
Copy link
Copy Markdown
Contributor

Is there any plan to merge this PR soon?

@Tianlin-Zhao
Copy link
Copy Markdown
Contributor Author

Is there any plan to merge this PR soon?

This is an old PR that I should have removed some time ago. Sorry for this confusion, please refer to #143 for my latest work.

@nadiaciobanu
Copy link
Copy Markdown
Contributor

Okay, thanks! In that case you could close this PR.

GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…o-7.x

Update dependency rules_proto to v7.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants