Skip to content

OTLP gRPC Metrics Exporter#1454

Merged
lalitb merged 24 commits intoopen-telemetry:mainfrom
lalitb:otlp-grpc-exporter
Jun 23, 2022
Merged

OTLP gRPC Metrics Exporter#1454
lalitb merged 24 commits intoopen-telemetry:mainfrom
lalitb:otlp-grpc-exporter

Conversation

@lalitb
Copy link
Copy Markdown
Member

@lalitb lalitb commented Jun 16, 2022

Fixes #1450

Changes

Adds initial implementation of OTLP gRPC exporter for metrics. While this is ready for review, I am currently adding

  • Unit tests
  • Histogram export

as part of this PR.

Also, the bazel build is breaking for nit issue. Will be fixing that too.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team June 16, 2022 07:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2022

Codecov Report

Merging #1454 (92427f3) into main (5ccca49) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
+ Coverage   85.30%   85.30%   +0.01%     
==========================================
  Files         154      154              
  Lines        4373     4374       +1     
==========================================
+ Hits         3730     3731       +1     
  Misses        643      643              
Impacted Files Coverage Δ
exporters/ostream/test/ostream_metric_test.cc 100.00% <ø> (ø)
sdk/src/metrics/state/temporal_metric_storage.cc 92.99% <100.00%> (+0.13%) ⬆️

Comment thread exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h Outdated
Comment thread exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter.h Outdated
Comment thread exporters/otlp/src/otlp_populate_attribute_utils.cc
@lalitb lalitb merged commit b285874 into open-telemetry:main Jun 23, 2022
@lalitb lalitb mentioned this pull request Jun 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTLP gRPC Exporter for Metrics

2 participants