Remove reference to deprecated InstrumentationLibrary in OTLP#1469
Merged
ThomsonTan merged 5 commits intoopen-telemetry:mainfrom Jun 29, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1469 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 154 154
Lines 4374 4374
=======================================
Hits 3731 3731
Misses 643 643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1381
We upgraded OTLP proto files to 0.17.0, but we are still using
InstrumentationLibraryin the OTLP message which was marked as deprecated, and this deprecated field is not compatible with previous OTLP message in wired format.This PR replaces
InstrumentationLibrarybyInstrumentationScopein the OTLP exporter to fix the broken compatibility. Fix for the SDK is expected to be in future PR.Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes