You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just wondering if the issue would be still valid once @owent async changes are merged, as that PR removes select call usage. Also, there was similar fix done for Linux - #1410 to replace select call with poll. If there is similar alternative for Windows ?
Just wondering if the issue would be still valid once @owent async changes are merged, as that PR removes select call usage. Also, there was similar fix done for Linux - #1410 to replace select call with poll. If there is similar alternative for Windows ?
@lalitb thanks for the reminder. Yes, the async change will remove current code with issue, so I think I could close this PR once the async change is merged. Also I think #1410 applies to Windows as well, right?
Also I think #1410 applies to Windows as well, right?
#1410 replaces select with poll only for POSIX and keeps select for Windows. Merging this PR will add more conflict with async PR. If this is not the blocker, we can let @owent to decide how to proceed with this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1476.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes