Skip to content

Add benchmark tests for OTLP exporter#163

Merged
reyang merged 13 commits into
open-telemetry:masterfrom
nadiaciobanu:otlp-benchmark
Jul 10, 2020
Merged

Add benchmark tests for OTLP exporter#163
reyang merged 13 commits into
open-telemetry:masterfrom
nadiaciobanu:otlp-benchmark

Conversation

@nadiaciobanu
Copy link
Copy Markdown
Contributor

@nadiaciobanu nadiaciobanu commented Jul 8, 2020

Benchmark Export() for the OTLP exporter using empty, sparse and dense spans. Empty spans are completely empty, sparse spans are minimal spans (containing name, ids, start time and duration) and dense spans also have attributes set.

Sample output using optimized build:

benchmark_output_optimized

@nadiaciobanu nadiaciobanu requested a review from a team July 8, 2020 21:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 8, 2020

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          74       74           
  Lines        1802     1802           
=======================================
  Hits         1696     1696           
  Misses        106      106           

Copy link
Copy Markdown
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This will give a good foundation for further optimization work.

Those are results from the CI pipeline, based on an optimized build:

2020-07-08 22:05:13
Running bazel-out/host/bin/exporters/otlp/otlp_exporter_benchmark
Run on (2 X 2394.45 MHz CPU s)
CPU Caches:
  L1 Data 32K (x2)
  L1 Instruction 32K (x2)
  L2 Unified 256K (x2)
  L3 Unified 30720K (x1)
Load Average: 2.04, 1.70, 0.86
--------------------------------------------------------------------
Benchmark                          Time             CPU   Iterations
--------------------------------------------------------------------
BM_OtlpExporterFullSpans      110022 ns       109842 ns         1323
BM_OtlpExporterEmptySpans      25786 ns        25787 ns         5400

Comment thread exporters/otlp/otlp_exporter_benchmark.cc
Comment thread exporters/otlp/otlp_exporter_benchmark.cc Outdated
Comment thread exporters/otlp/otlp_exporter_benchmark.cc Outdated
Comment thread exporters/otlp/otlp_exporter_benchmark.cc
Comment thread exporters/otlp/otlp_exporter_benchmark.cc Outdated
Copy link
Copy Markdown
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread exporters/otlp/otlp_exporter_benchmark.cc Outdated
Comment thread exporters/otlp/otlp_exporter_benchmark.cc Outdated
@ZiweiZhao
Copy link
Copy Markdown

LGTM :)

Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nadiaciobanu
Copy link
Copy Markdown
Contributor Author

@reyang Ready to merge! :)

@reyang
Copy link
Copy Markdown
Member

reyang commented Jul 10, 2020

@nadiaciobanu would you rebase? Thanks.

@reyang reyang merged commit af0a946 into open-telemetry:master Jul 10, 2020
@nadiaciobanu nadiaciobanu deleted the otlp-benchmark branch July 23, 2020 22:33
@reyang reyang mentioned this pull request Aug 25, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…e-3.x

Update dependency rules_apple to v3.17.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants