Move SpanContext to Separate File#168
Merged
reyang merged 12 commits intoJul 13, 2020
Merged
Conversation
pyohannes
reviewed
Jul 10, 2020
nholbrook
force-pushed
the
nholbrook/move_span_context
branch
from
c33c203 to
316e720
Compare
nholbrook
force-pushed
the
nholbrook/move_span_context
branch
from
316e720 to
2130ef0
Compare
pyohannes
reviewed
Jul 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 94.11% 94.17% +0.05%
==========================================
Files 74 76 +2
Lines 1802 1820 +18
==========================================
+ Hits 1696 1714 +18
Misses 106 106
|
jsandler18
approved these changes
Jul 13, 2020
pyohannes
approved these changes
Jul 13, 2020
Contributor
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
This looks good. Can we add a TODO in span_context.h to indicate that this is just a stub for now that needs to be revisited?
Contributor
|
That looks good, @reyang please have a look. This is not yet a fully featured |
reyang
reviewed
Jul 13, 2020
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
…-cpp-1.x Update dependency prometheus-cpp to v1.3.0.bcr.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup on comment #136 (comment).
Since the ParentOrElse Sampler got merged, the CI tests are throwing errors on my Probability Sampler PR due to duplicate definitions of SpanContext in multiple files. This needs to be merged before #136 can be merged.