Prepare v1.7.0 release with Metrics API/SDK GA. by esigo · Pull Request #1721 · open-telemetry/opentelemetry-cpp

esigo · 2022-10-28T16:32:31Z

No description provided.

codecov · 2022-10-28T16:43:56Z

Codecov Report

❗ No coverage uploaded for pull request base (main@dd7e257). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1721   +/-   ##
=======================================
  Coverage        ?   85.79%           
=======================================
  Files           ?      171           
  Lines           ?     5212           
  Branches        ?        0           
=======================================
  Hits            ?     4471           
  Misses          ?      741           
  Partials        ?        0

lalitb · 2022-10-28T17:14:27Z

Just to add - This PR is also the meant to be GA release for Metrics API and SDK. If there are PRs or issues which should block this release, comment below and we can discuss further here.

Co-authored-by: Tom Tan <lilotom@gmail.com>

Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>

ThomsonTan · 2022-10-28T18:10:52Z

+* [METRICS SDK] Fix data race on MeterContext::meters_ [#1668](https://github.com/open-telemetry/opentelemetry-cpp/pull/1668)
+* [METRICS SDK] Fix observable Gauge metrics generation [#1651](https://github.com/open-telemetry/opentelemetry-cpp/pull/1651)
+* [BUILD] Detect ARCH=sparc in CMake [#1660](https://github.com/open-telemetry/opentelemetry-cpp/pull/1660)
+* Add user agent for OTLP http/grpc client [#1657](https://github.com/open-telemetry/opentelemetry-cpp/pull/1657)


Missing tag here, [SDK]?

thanks, added the tag

ThomsonTan · 2022-10-28T18:13:01Z

+and change default bucket range [#1626](https://github.com/open-telemetry/opentelemetry-cpp/pull/1626)
+* [METRICS SDK] Fix occasional Segfault with LongCounter instrument [#1638](https://github.com/open-telemetry/opentelemetry-cpp/pull/1638)
+* [BUILD] Bump vcpk to 2022.08.15 [#1633](https://github.com/open-telemetry/opentelemetry-cpp/pull/1633)
+* [BUILD] Bump gRPC to v1.48.1 for CMake Linux CI [#1608](https://github.com/open-telemetry/opentelemetry-cpp/pull/1608)


Add a notes section on the end to include the breaking changes for metrics preview customers?

thanks added the note:

Notes:

Metrics API/SDK GA release includes PRs #1686, #1701, and #1707 with breaking changes in the Metrics API and SDK.

ThomsonTan · 2022-10-28T18:15:16Z

 const char *FULL_VERSION =
-    "1.6.0-NONE-NONE-27-pre_release_1.6.1-38012fab34faa50d5020959b68eba77ac485b508";
+    "1.7.0-NONE-NONE-35-pre_release_1.7.0-dd7e257b6de71eeaf9e3149530962301705b9a0d";
 const char *BUILD_DATE = "Thu Sep 22 18:05:21 UTC 2022";


buildscripts/pre-commit should update the BUILD_DATE here?

thanks, updated

lalitb

Thank you, and nicely done - even though it was the first release :)

ThomsonTan

LGTM once the format is fixed. Thanks @esigo

marcalff

LGTM, see comment for changelog.

marcalff · 2022-10-28T20:07:49Z

+which includes breaking change in the Metrics api and sdk.
+* [BUILD] Add e2e test to asan & tsan CI [#1670](https://github.com/open-telemetry/opentelemetry-cpp/pull/1670)
+* [BUILD] Add otlp-grpc example bazel [#1708](https://github.com/open-telemetry/opentelemetry-cpp/pull/1708)
+* Fix debug log of OTLP HTTP exporter and ES log exporter [#1703](https://github.com/open-telemetry/opentelemetry-cpp/pull/1703)


Add [TRACE SDK] for 1703

thanks, added

…ad-local-stack * commit '9acde87b08b225ce511fa8a20c6cba14f2921518': (36 commits) Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721) Fix: 1712 - Validate Instrument meta data (name, unit, description) (open-telemetry#1713) Document libthrift 0.12.0 doesn't work with Jaeger exporter (open-telemetry#1714) Fix:1674, Add Monotonic Property to Sum Aggregation, and unit tests for Up Down Counter (open-telemetry#1675) [Metrics SDK] Move Metrics Exemplar processing behind feature flag (open-telemetry#1710) [Metrics API/SDK] Change Meter API/SDK to return nostd::unique_ptr for Sync Instruments (open-telemetry#1707) [Metrics] Switch to explicit 64 bit integers (open-telemetry#1686) Add metrics e2e test to asan & tsan CI (open-telemetry#1670) Add otlp-grpc example bazel (open-telemetry#1708) [Metrics SDK] Add support for Pull Metric Reader (open-telemetry#1701) Fix debug log of OTLP HTTP exporter and ES log exporter (open-telemetry#1703) [SEMANTIC CONVENTIONS] Upgrade to version 1.14.0 (open-telemetry#1697) Fix a potential precision loss on integer in ReservoirCellIndexFor (open-telemetry#1696) fix Histogram crash (open-telemetry#1685) Fix:1676 Segfault when short export period is used for metrics (open-telemetry#1682) Add timeout support to MeterContext::ForceFlush (open-telemetry#1673) Add CMake OTELCPP_MAINTAINER_MODE (open-telemetry#1650) [DOCS] - Minor updates to OStream Metrics exporter documentation (open-telemetry#1679) Fix:open-telemetry#1575 API Documentation for Metrics SDK and API (open-telemetry#1678) Fixes open-telemetry#249 (open-telemetry#1677) ...

esigo added 3 commits October 28, 2022 15:45

Prepare for releasing 1.7.0

973ea73

update version

1f4d9fa

changelog

b7fd26b

esigo requested a review from a team October 28, 2022 16:32

fix CI

0ca3605

fix CI

e961d06

lalitb changed the title ~~Prepare v1.7.0 release~~ Prepare v1.7.0 release with Metrics API/SDK GA. Oct 28, 2022

ThomsonTan reviewed Oct 28, 2022

View reviewed changes

Comment thread CHANGELOG.md Outdated

Update CHANGELOG.md

8bd58b9

Co-authored-by: Tom Tan <lilotom@gmail.com>

lalitb reviewed Oct 28, 2022

View reviewed changes

Comment thread CHANGELOG.md

Update CHANGELOG.md

0273c5d

Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>

ThomsonTan reviewed Oct 28, 2022

View reviewed changes

comments

dbc3963

lalitb approved these changes Oct 28, 2022

View reviewed changes

ThomsonTan approved these changes Oct 28, 2022

View reviewed changes

format

52f2397

marcalff approved these changes Oct 28, 2022

View reviewed changes

comment

080a931

esigo merged commit 9acde87 into open-telemetry:main Oct 28, 2022

esigo deleted the pre_release_1.7.0 branch October 28, 2022 22:02

yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022

Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721)

399daf5

yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022

Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721)

c7bd2d7

Conversation

esigo commented Oct 28, 2022

Uh oh!

codecov Bot commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lalitb commented Oct 28, 2022

Uh oh!

Uh oh!

Uh oh!

ThomsonTan Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

esigo Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

ThomsonTan Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

esigo Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

ThomsonTan Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

esigo Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

lalitb left a comment

Choose a reason for hiding this comment

Uh oh!

ThomsonTan left a comment

Choose a reason for hiding this comment

Uh oh!

marcalff left a comment

Choose a reason for hiding this comment

Uh oh!

marcalff Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

esigo Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Oct 28, 2022 •

edited

Loading

ThomsonTan Oct 28, 2022 •

edited

Loading