Comprehensive test#173
Merged
Merged
Conversation
jsandler18
reviewed
Jul 15, 2020
jsandler18
suggested changes
Jul 15, 2020
jsandler18
left a comment
jsandler18
left a comment
There was a problem hiding this comment.
I am not sure if this qualifies as "integration tests". These seem more like comprehensive unit tests, which is great, but not exactly what you said.
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=========================================
Coverage ? 95.56%
=========================================
Files ? 91
Lines ? 2548
Branches ? 0
=========================================
Hits ? 2435
Misses ? 113
Partials ? 0
|
Contributor
Author
Yeah, we discussed in the SIG meeting and agreed to write a comprehensive unit test instead of an "integration" test. |
jsandler18
approved these changes
Jul 15, 2020
pyohannes
reviewed
Jul 15, 2020
added 2 commits
July 16, 2020 00:44
reyang
added
the
pr:please-merge
oulin-coder
reviewed
Jul 16, 2020
pyohannes
approved these changes
Jul 16, 2020
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
…s-create-or-update-comment-digest Update peter-evans/create-or-update-comment digest to 362dbaf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a comprehensive ("integration") test case in `tracer_test.cc". I tried all possible combinations of samplers and tested its functionality in the tracer.