Skip to content

Sampler Performance Testing#175

Merged
reyang merged 15 commits into
open-telemetry:masterfrom
ziqizh:nholbrook/performance_testing
Jul 23, 2020
Merged

Sampler Performance Testing#175
reyang merged 15 commits into
open-telemetry:masterfrom
ziqizh:nholbrook/performance_testing

Conversation

@nholbrook
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread sdk/test/trace/sampler_benchmark.cc
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2020

Codecov Report

Merging #175 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files          96       96           
  Lines        2878     2878           
=======================================
  Hits         2754     2754           
  Misses        124      124           

@nholbrook nholbrook changed the title [WIP] Performance Testing Performance Testing Jul 15, 2020
@nholbrook nholbrook changed the title Performance Testing Sampler Performance Testing Jul 15, 2020
Comment thread sdk/test/trace/sampler_benchmark.cc Outdated
Comment thread sdk/test/trace/sampler_benchmark.cc
Comment thread sdk/test/trace/sampler_benchmark.cc
@nholbrook
Copy link
Copy Markdown
Contributor Author

Current Benchmark Results:

Benchmark Time CPU Iterations
BM_AlwaysOffSamplerConstruction 1.92 ns 1.67 ns 100000000
BM_AlwaysOnSamplerConstruction 1.89 ns 1.89 ns 74647736
BM_ParentOrElseSamplerConstruction 204 ns 203 ns 706505
BM_ProbabilitySamplerConstruction 372 ns 372 ns 387424
BM_AlwaysOffSamplerShouldSample 3.34 ns 3.34 ns 41949892
BM_AlwaysOnSamplerShouldSample 3.14 ns 3.14 ns 45300132
BM_ParentOrElseSamplerShouldSample 6.27 ns 6.27 ns 22260191
BM_ProbabilitySamplerShouldSample 5.38 ns 5.38 ns 26910475
BM_SpanCreation 657 ns 657 ns 207378
BM_NoopSpanCreation 56.1 ns 56.1 ns 2472011

Comment thread sdk/test/trace/sampler_benchmark.cc Outdated
Comment thread sdk/test/trace/sampler_benchmark.cc
Comment thread sdk/test/trace/sampler_benchmark.cc
Comment thread sdk/test/trace/sampler_benchmark.cc Outdated
Comment thread sdk/test/trace/sampler_benchmark.cc
Comment thread sdk/test/trace/sampler_benchmark.cc Outdated
@nholbrook nholbrook marked this pull request as ready for review July 20, 2020 10:55
@nholbrook nholbrook requested a review from a team July 20, 2020 10:55
Copy link
Copy Markdown
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks. Results look good, the BM_NoopSpanCreation test will for sure be useful for further optimization work.

Comment thread sdk/test/trace/sampler_benchmark.cc
Comment thread sdk/test/trace/sampler_benchmark.cc
Comment thread sdk/test/trace/sampler_benchmark.cc Outdated
@pyohannes pyohannes added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jul 21, 2020
@pyohannes
Copy link
Copy Markdown
Contributor

This is ready to be merged @reyang.

@reyang
Copy link
Copy Markdown
Member

reyang commented Jul 23, 2020

Looks like there is a Bazel update again - which caused the CI to fail. Not blocking this PR merge though.

@reyang reyang merged commit 5b8cd5b into open-telemetry:master Jul 23, 2020
@reyang reyang mentioned this pull request Aug 25, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…-20250127.x

Update dependency abseil-cpp to v20250127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants