Skip to content

zPages: Threadsafe recordable#192

Merged
reyang merged 10 commits into
open-telemetry:masterfrom
kmanghat:zpages-threadsafe-recordable
Jul 28, 2020
Merged

zPages: Threadsafe recordable#192
reyang merged 10 commits into
open-telemetry:masterfrom
kmanghat:zpages-threadsafe-recordable

Conversation

@kmanghat
Copy link
Copy Markdown
Contributor

@kmanghat kmanghat commented Jul 20, 2020

This PR contains additions for a threadsafe recordable that will be used for tracez zpage. The recordable is similar to SpanData with the addition of thread safety for it's functions.

@kmanghat kmanghat requested a review from a team July 20, 2020 21:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 20, 2020

Codecov Report

Merging #192 into master will increase coverage by 0.13%.
The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   92.31%   92.45%   +0.13%     
==========================================
  Files         102      103       +1     
  Lines        3174     3259      +85     
==========================================
+ Hits         2930     3013      +83     
- Misses        244      246       +2     
Impacted Files Coverage Δ
...de/opentelemetry/ext/zpages/threadsafe_span_data.h 96.29% <96.29%> (ø)
ext/test/zpages/threadsafe_span_data_test.cc 100.00% <100.00%> (ø)
sdk/include/opentelemetry/sdk/trace/span_data.h 98.33% <0.00%> (ø)
sdk/include/opentelemetry/sdk/trace/recordable.h 100.00% <0.00%> (ø)
...nclude/opentelemetry/sdk/common/empty_attributes.h

@kmanghat kmanghat changed the title Zpages threadsafe recordable zPages: Threadsafe recordable Jul 20, 2020
Comment thread ext/include/opentelemetry/ext/zpages/threadsafe_span_data.h
@pyohannes pyohannes added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jul 27, 2020
@reyang reyang merged commit de0033f into open-telemetry:master Jul 28, 2020
ziqizh pushed a commit to ziqizh/opentelemetry-cpp that referenced this pull request Jul 31, 2020
ziqizh pushed a commit to ziqizh/opentelemetry-cpp that referenced this pull request Jul 31, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
[ETW] Add configuration to export 64-bit integer as timestamp (open-telemetry#3286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants