change Sampler description from string to string_view#193
Merged
Conversation
ziqizh
changed the title
ziqizh
force-pushed
the
change-description
branch
from
bd94aae to
91075ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
- Coverage 95.69% 95.68% -0.01%
==========================================
Files 96 96
Lines 2878 2877 -1
==========================================
- Hits 2754 2753 -1
Misses 124 124
|
jsandler18
approved these changes
Jul 21, 2020
oulin-coder
reviewed
Jul 21, 2020
pyohannes
approved these changes
Jul 21, 2020
pyohannes
added
the
pr:please-merge
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
Update dependency bazel to v8.1.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the return value of
GetDescription()fromstringtostring_viewto improve efficiency.Now the description is created in construction time.