Support links and event attributes in Recordable#197
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 95.72% 95.69% -0.04%
==========================================
Files 96 96
Lines 2877 2878 +1
==========================================
Hits 2754 2754
- Misses 123 124 +1
|
reyang
reviewed
Jul 21, 2020
pyohannes
reviewed
Jul 21, 2020
reyang
reviewed
Jul 21, 2020
reyang
added
the
pr:please-merge
nadiaciobanu
changed the title
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
…el_lib-2.x Update dependency aspect_bazel_lib to v2.14.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
Recordablebase class to support links and attributes in events. The implementation of these will be handled in further PRs.