Add OPENTELEMETRY_INSTALL to allow user to skip install targets.#2022
Merged
lalitb merged 3 commits intoopen-telemetry:mainfrom Mar 7, 2023
Merged
Add OPENTELEMETRY_INSTALL to allow user to skip install targets.#2022lalitb merged 3 commits intoopen-telemetry:mainfrom
OPENTELEMETRY_INSTALL to allow user to skip install targets.#2022lalitb merged 3 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: owent <admin@owent.net>
Signed-off-by: owent <admin@owent.net>
dbolduc
reviewed
Mar 8, 2023
Comment on lines
+121
to
+124
| if(NOT CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) | ||
| set(OPENTELEMETRY_INSTALL_default ON) | ||
| else() | ||
| set(OPENTELEMETRY_INSTALL_default OFF) |
Contributor
There was a problem hiding this comment.
(Maybe this is too late now, but) Do you think this should default to ON in all cases for backwards compatibility?
Do you think the new feature should be listed in INSTALL.md?
Lines 75 to 86 in f702676
Member
There was a problem hiding this comment.
(Maybe this is too late now, but) Do you think this should default to ON in all cases for backwards compatibility?
True, somehow missed this during review. Not sure if reverting back would be good idea as the release is already done now. We can mention this in release summary as breaking change for builds cc @ThomsonTan ?
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2015
Changes
OPENTELEMETRY_INSTALLto allow user to skip install targets.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes