Skip to content

Implement links and event attributes in OTLP Recordable#210

Merged
reyang merged 6 commits into
open-telemetry:masterfrom
nadiaciobanu:otlp-recordable
Jul 27, 2020
Merged

Implement links and event attributes in OTLP Recordable#210
reyang merged 6 commits into
open-telemetry:masterfrom
nadiaciobanu:otlp-recordable

Conversation

@nadiaciobanu
Copy link
Copy Markdown
Contributor

@nadiaciobanu nadiaciobanu commented Jul 24, 2020

Add implementation for links and event attributes to the OTLP Recordable. Links only support adding attributes for now, since SpanContext doesn't support trace_id, span_id or trace_state yet.

@nadiaciobanu nadiaciobanu requested a review from a team July 24, 2020 23:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 24, 2020

Codecov Report

Merging #210 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files         101      101           
  Lines        3169     3169           
=======================================
  Hits         2925     2925           
  Misses        244      244           

Copy link
Copy Markdown
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment thread exporters/otlp/src/recordable.cc
@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jul 27, 2020
@reyang
Copy link
Copy Markdown
Member

reyang commented Jul 27, 2020

This is a build failure which doesn't seem to be related to this PR (seems to be related to changes from external dependency)

@reyang reyang merged commit 60f6920 into open-telemetry:master Jul 27, 2020
ziqizh pushed a commit to ziqizh/opentelemetry-cpp that referenced this pull request Jul 31, 2020
ziqizh pushed a commit to ziqizh/opentelemetry-cpp that referenced this pull request Jul 31, 2020
@nadiaciobanu nadiaciobanu deleted the otlp-recordable branch August 4, 2020 16:32
@reyang reyang mentioned this pull request Aug 25, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…monorepo

Update dependency grpc-java to v1.71.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants