zPages: Switching from using SpanData to custom recordable created for zPages#220
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 92.19% 94.25% +2.05%
==========================================
Files 117 115 -2
Lines 4038 3881 -157
==========================================
- Hits 3723 3658 -65
+ Misses 315 223 -92
|
maxgolov
approved these changes
Jul 31, 2020
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
…s-create-or-update-comment-digest chore(deps): update peter-evans/create-or-update-comment digest to 227bde7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the tracez_processor uses SpanData as the recordable for zpages. This PR switches from using SpanData to ThreadsafeSpanData which is a custom recordable created specifically for zpages.