Skip to content

Added a copy constructor for zpages recordable#227

Merged
reyang merged 9 commits into
open-telemetry:masterfrom
kmanghat:threadsafe-recordable-update
Aug 4, 2020
Merged

Added a copy constructor for zpages recordable#227
reyang merged 9 commits into
open-telemetry:masterfrom
kmanghat:threadsafe-recordable-update

Conversation

@kmanghat
Copy link
Copy Markdown
Contributor

This PR adds a copy constructor to the zpages recordable. By default there is no copy constructor for classes with mutex within them hence if copies need to be made a custom copy constructor is required.

@kmanghat kmanghat requested a review from a team July 29, 2020 18:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 29, 2020

Codecov Report

Merging #227 into master will increase coverage by 2.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   92.19%   94.23%   +2.03%     
==========================================
  Files         117      115       -2     
  Lines        4038     3883     -155     
==========================================
- Hits         3723     3659      -64     
+ Misses        315      224      -91     
Impacted Files Coverage Δ
...de/opentelemetry/ext/zpages/threadsafe_span_data.h 96.36% <100.00%> (+0.06%) ⬆️
sdk/src/metrics/meter_provider.cc 100.00% <0.00%> (ø)
api/include/opentelemetry/metrics/meter.h
api/test/metrics/noop_metrics_test.cc
api/include/opentelemetry/metrics/noop.h 45.91% <0.00%> (+0.88%) ⬆️
sdk/include/opentelemetry/sdk/metrics/meter.h 100.00% <0.00%> (+93.33%) ⬆️

@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jul 30, 2020
@kmanghat kmanghat requested a review from reyang August 3, 2020 16:27
@reyang reyang added pr:do-not-merge This PR is not ready to be merged. and removed pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) labels Aug 3, 2020
@kmanghat kmanghat closed this Aug 4, 2020
@kmanghat kmanghat reopened this Aug 4, 2020
@reyang reyang added pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) and removed pr:do-not-merge This PR is not ready to be merged. labels Aug 4, 2020
@reyang reyang merged commit 60ea900 into open-telemetry:master Aug 4, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…eql-action-3.x

chore(deps): update github/codeql-action action to v3.28.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants