Fix Metrics SDK CMake tests#230
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 93.99% 94.22% +0.23%
==========================================
Files 111 115 +4
Lines 3661 3877 +216
==========================================
+ Hits 3441 3653 +212
- Misses 220 224 +4
|
reyang
added
the
pr:please-merge
erichsueh3
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In resolving merge conflicts in my Exact aggregator PR I accidentally removed the counter_aggregator and histogram_aggregator tests from sdk/test/metrics/CMakeLists.txt. This PR simply adds those back.
My apologies.