Skip to content

pass in library_name and library_version into meter #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reyang merged 2 commits into from
Jul 30, 2020
Merged

pass in library_name and library_version into meter #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23df198
pass in library_name and library_version into meter
HudsonHumphries Jul 30, 2020
b306351
formatting
HudsonHumphries Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sdk/include/opentelemetry/sdk/metrics/meter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include "opentelemetry/version.h"

#include <memory>
#include <string>

OPENTELEMETRY_BEGIN_NAMESPACE
namespace sdk
Expand All @@ -13,6 +14,15 @@ namespace metrics
class Meter final : public opentelemetry::metrics::Meter, public std::enable_shared_from_this<Meter>
{
public:
explicit Meter(std::string library_name, std::string library_version)
{
library_name_ = library_name;
library_version_ = library_version;
}

private:
std::string library_name_;
std::string library_version_;
};
} // namespace metrics
} // namespace sdk
Expand Down
3 changes: 2 additions & 1 deletion sdk/include/opentelemetry/sdk/metrics/meter_provider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "opentelemetry/sdk/metrics/meter.h"

#include <memory>
#include <string>

OPENTELEMETRY_BEGIN_NAMESPACE
namespace sdk
Expand All @@ -17,7 +18,7 @@ class MeterProvider final : public opentelemetry::metrics::MeterProvider
/**
* Initialize a new meter provider
*/
explicit MeterProvider() noexcept;
explicit MeterProvider(std::string library_name = "", std::string library_version = "") noexcept;

opentelemetry::nostd::shared_ptr<opentelemetry::metrics::Meter> GetMeter(
nostd::string_view library_name,
Expand Down
4 changes: 3 additions & 1 deletion sdk/src/metrics/meter_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ namespace sdk
{
namespace metrics
{
MeterProvider::MeterProvider() noexcept : meter_(new Meter) {}
MeterProvider::MeterProvider(std::string library_name, std::string library_version) noexcept
: meter_(new Meter(library_name, library_version))
{}

opentelemetry::nostd::shared_ptr<opentelemetry::metrics::Meter> MeterProvider::GetMeter(
nostd::string_view library_name,
Expand Down