[Metrics] Make context optional for histogram instruments in Metrics SDK#2416
Merged
ThomsonTan merged 4 commits intoopen-telemetry:mainfrom Nov 29, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
==========================================
- Coverage 87.41% 87.06% -0.35%
==========================================
Files 199 199
Lines 6052 6079 +27
==========================================
+ Hits 5290 5292 +2
- Misses 762 787 +25
|
lalitb
approved these changes
Nov 29, 2023
Member
lalitb
left a comment
There was a problem hiding this comment.
Thanks for the fix. Nicely done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2155
Changes
This PR extracts the context related change in #2341, also the change of making
LongCounterandLongHistogramas unsigned type is picked up.CHANGELOG.mdupdated for non-trivial changes