-
Notifications
You must be signed in to change notification settings - Fork 566
Add Prometheus Exporter - Utils Unit Tests #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
CunjunWang
wants to merge
8
commits into
open-telemetry:master
from
CunjunWang:prom-exporter-utils-test
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e43bba5
add test cases for prometheus exporter utils
CunjunWang 3131e2c
add test case for parsing Sketch to Prometheus Summary
CunjunWang ac4488c
add copyright headers and add a new line at the end of file
CunjunWang 26f3077
run format script
CunjunWang 4e3a235
Add a test case for parsing Exact Aggregator to a summary without qua…
CunjunWang 0cda53d
add CMakeLists.txt file for test directory
CunjunWang 065880a
add CMakeLists.txt file for test directory; add copyright header
CunjunWang c6f2919
change test for default quantiles
CunjunWang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Copyright 2020, OpenTelemetry Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| foreach ( | ||
| testname | ||
| prometheus_exporter_utils_test | ||
| prometheus_collector_test | ||
| prometheus_exporter_test) | ||
| add_executable(${testname} "${testname}.cc") | ||
| target_link_libraries( | ||
| ${testname} ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT} | ||
| prometheus_exporter prometheus-cpp::pull) | ||
| gtest_add_tests(TARGET ${testname} TEST_PREFIX exporter. TEST_LIST ${testname}) | ||
| endforeach () | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you combine this unit tests with the piece of code that is tested into one PR? And provide Bazel build support for it, as well as hooking it into the global CMake build by adding the prometheus directory as a subdirectory to
exporters/CMakeLists.txt?I would greatly help the reviewing process to have those tests running in the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can do that, but I am worrying that the combined PR will be so big. We have three unit test files that contain more than 1000 lines. Can we have such a large PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to have each PR buildable, with unit tests that cover the added new functionality. If the only way to ensure that is a bigger PR, than I think it's better to have a bigger PR.
Maybe you can have three PRs: first the exporter utils with unit tests, second the collector with unit tests based on the first, and third the exporter with unit tests based on the second. We can then review and merge from first to third, rebasing later ones when previous ones got merged.