Set ids for spans#290
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 93.94% 93.93% -0.01%
==========================================
Files 146 146
Lines 6538 6564 +26
==========================================
+ Hits 6142 6166 +24
- Misses 396 398 +2
|
pyohannes
reviewed
Aug 22, 2020
lalitb
reviewed
Aug 24, 2020
|
LGTM |
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
…ld-push-action-6.x chore(deps): update docker/build-push-action action to v6.17.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
trace_id,span_idandparent_span_idfor spans using a random buffer generator.Currently, the
Spanclass does not support extracting the span context from a span (this functionality will be added in #143). For now, we create an invalid parent span context in the tracer and pass it to the span constructor. Since the parent span context is invalid,Spanalways generates new ids (rather than settingtrace_idandparent_span_idbased on the parent context).Once
Spansupports extracting the span context, the parent span context will be extracted in the tracer, and passed into theSpanconstructor. The constructor will create a span context for the new span and set the ids in that context using the parent span context. Here is the issue for tracking this work: #285.This change requires adding support for
trace_idandspan_idinSpanContext. SinceSpanContextis not fully implemented yet (implemented in #143),trace_idandspan_idare set to invalid (all zeros).