Restructure Ext folder#292
Closed
jajanet wants to merge 9 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 93.93% 93.93%
=======================================
Files 146 146
Lines 6564 6564
=======================================
Hits 6166 6166
Misses 398 398
|
Contributor
Author
|
Likely replacing the HTTP client in the future, so restructuring changes no longer needed. See #309 |
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
…obuf-monorepo chore(deps): update dependency protobuf to v31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to restructure and move all HTTP server and zPages code so that they're grouped in separate locations, meaning they can be used and included by themselves as needed. They're currently tightly coupled, so adding the HTTP server headers also includes zPages--this is not ideal. The zPages README location was also odd since there were 3 zpages folders (in include, src, and test), and now the new location (1 single zpages folder) makes more sense.
With that, this also ensures future ext additions aren't tightly coupled with the HTTP server and zPages. The number of CMake files are reduced, making future maintenance and development easier.
#288 should be merged before this.