Add logic to refrain from exporting un-updated metric instruments#293
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 93.93% 94.43% +0.50%
==========================================
Files 146 146
Lines 6564 6597 +33
==========================================
+ Hits 6166 6230 +64
+ Misses 398 367 -31
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to resolve Issue #255.
I have added a new bool variable to the aggregator base class to track whether or not the aggregator has been updated in the most recent collection cycle. Some additional logic was then added to the SDK sync instrument classes to refrain from creating records from aggregators that have received no recent updates. Since there are no records created from these un-updated (stale) instruments, they will not be exported.
I did not implement the same logic for the SDK async instrument classes as I don't believe it would make sense there. Asynchronous instruments are supposed to be exported by interval rather than by request: Therefore they are never stale.