Skip to content

Add OTLP exporter configuration#295

Merged
reyang merged 6 commits into
open-telemetry:masterfrom
nadiaciobanu:exporter-config
Aug 25, 2020
Merged

Add OTLP exporter configuration#295
reyang merged 6 commits into
open-telemetry:masterfrom
nadiaciobanu:exporter-config

Conversation

@nadiaciobanu
Copy link
Copy Markdown
Contributor

Add an options struct to the OTLP exporter to allow exporter configuration (see OTLP exporter spec). Add a new OTLP exporter constructor that accepts and sets these options.

This PR adds an endpoint configuration, with a default of localhost:55680. In the future, other configuration options will be added, such as timeout.

Note that this PR changes the default port used to connect to the OpenTelemetry Collector from 55678 to 55680, in accordance with #239.

@nadiaciobanu nadiaciobanu requested a review from a team August 25, 2020 00:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2020

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         146      146           
  Lines        6597     6597           
=======================================
  Hits         6230     6230           
  Misses        367      367           

Comment thread exporters/otlp/include/opentelemetry/exporters/otlp/otlp_exporter.h Outdated
@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Aug 25, 2020
Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown

@IlyaKobelevskiy IlyaKobelevskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread exporters/otlp/include/opentelemetry/exporters/otlp/otlp_exporter.h Outdated
Comment thread exporters/otlp/test/otlp_exporter_test.cc Outdated
Copy link
Copy Markdown

@ZiweiZhao ZiweiZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadiaciobanu
Copy link
Copy Markdown
Contributor Author

@reyang Ready to merge!

@reyang reyang merged commit ec6f70d into open-telemetry:master Aug 25, 2020
@nadiaciobanu nadiaciobanu deleted the exporter-config branch August 25, 2020 22:46
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…eql-action-3.x

chore(deps): update github/codeql-action action to v3.28.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants