Skip to content

Add OTLP exporter example#296

Merged
reyang merged 5 commits into
open-telemetry:masterfrom
nadiaciobanu:otlp-example
Aug 26, 2020
Merged

Add OTLP exporter example#296
reyang merged 5 commits into
open-telemetry:masterfrom
nadiaciobanu:otlp-example

Conversation

@nadiaciobanu
Copy link
Copy Markdown
Contributor

@nadiaciobanu nadiaciobanu commented Aug 25, 2020

Add an example application using the OTLP exporter. The example includes a detailed README with instructions on how to configure the OpenTelemetry Collector to use the OTLP exporter.

Currently, foo_library makes explicit calls to span->End() to work around #287. These calls should be removed once the issue is resolved. I've added a TODO in the code for this.

@nadiaciobanu nadiaciobanu requested a review from a team August 25, 2020 19:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2020

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         146      146           
  Lines        6597     6597           
=======================================
  Hits         6230     6230           
  Misses        367      367           

Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Aug 26, 2020
@reyang reyang merged commit eb04081 into open-telemetry:master Aug 26, 2020
Copy link
Copy Markdown

@IlyaKobelevskiy IlyaKobelevskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread examples/otlp/main.cc
@nadiaciobanu nadiaciobanu deleted the otlp-example branch August 26, 2020 21:21
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants