Skip to content

Add missing include folders for example OTLP exporter#300

Closed
ThomsonTan wants to merge 1 commit into
open-telemetry:masterfrom
ThomsonTan:FixExampleOtlpExporter
Closed

Add missing include folders for example OTLP exporter#300
ThomsonTan wants to merge 1 commit into
open-telemetry:masterfrom
ThomsonTan:FixExampleOtlpExporter

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

Added missing included folders and also renamed library target foo_library to otlp_foo_library in CMakeLists.txt. The name foo_library conflicts with the library in simple example.

gRPC dependency is still missing so I didn't add this exporter to the parent CMakeLists.txt, will fix it later.

@ThomsonTan ThomsonTan requested a review from a team August 26, 2020 17:55
@linux-foundation-easycla
Copy link
Copy Markdown

CLA Check

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2020

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files         146      146           
  Lines        6610     6610           
=======================================
  Hits         6250     6250           
  Misses        360      360           

@ThomsonTan
Copy link
Copy Markdown
Contributor Author

Will fix user Id and resend this PR.

@ThomsonTan ThomsonTan closed this Aug 26, 2020
@ThomsonTan ThomsonTan deleted the FixExampleOtlpExporter branch November 9, 2020 09:08
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
[SDK] Fix Base2ExponentialHistogramAggregation Merge with empty bucke…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant