Skip to content

Add missing include folders for example OTLP exporter#301

Merged
reyang merged 4 commits into
open-telemetry:masterfrom
ThomsonTan:FixExampleOtlpExporter1
Sep 1, 2020
Merged

Add missing include folders for example OTLP exporter#301
reyang merged 4 commits into
open-telemetry:masterfrom
ThomsonTan:FixExampleOtlpExporter1

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

Added missing included folders and also renamed library target foo_library to otlp_foo_library in CMakeLists.txt. The name foo_library conflicts with the library in simple example.

gRPC dependency is still missing so I didn't add this exporter to the parent CMakeLists.txt, will fix it later.

@ThomsonTan ThomsonTan requested a review from a team August 26, 2020 18:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2020

Codecov Report

Merging #301 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files         146      146           
  Lines        6629     6629           
=======================================
  Hits         6271     6271           
  Misses        358      358           

@lalitb
Copy link
Copy Markdown
Member

lalitb commented Aug 27, 2020

LGTM.

@ThomsonTan
Copy link
Copy Markdown
Contributor Author

Thanks. @reyang could you please also help approve and merge this?

@reyang
Copy link
Copy Markdown
Member

reyang commented Aug 28, 2020

Thanks. @reyang could you please also help approve and merge this?

CI is failing, need to get it fixed.

https://github.com/open-telemetry/opentelemetry-cpp/blob/master/CONTRIBUTING.md#how-to-receive-comments

By default I will ignore PRs that failed CI.

Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Aug 31, 2020
@reyang reyang merged commit a75d4e1 into open-telemetry:master Sep 1, 2020
@ThomsonTan ThomsonTan deleted the FixExampleOtlpExporter1 branch November 9, 2020 09:08
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants