Add missing include folders for example OTLP exporter#301
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 146 146
Lines 6629 6629
=======================================
Hits 6271 6271
Misses 358 358 |
Member
|
LGTM. |
lalitb
approved these changes
Aug 27, 2020
Contributor
Author
|
Thanks. @reyang could you please also help approve and merge this? |
Member
CI is failing, need to get it fixed. By default I will ignore PRs that failed CI. |
6 tasks
6 tasks
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
[SDK] Fix MetricProducer interface (open-telemetry#3413)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing included folders and also renamed library target
foo_librarytootlp_foo_libraryin CMakeLists.txt. The namefoo_libraryconflicts with the library in simple example.gRPC dependency is still missing so I didn't add this exporter to the parent CMakeLists.txt, will fix it later.