[Code Health] Clang Tidy cleanup, Part 2#3038
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3038 +/- ##
==========================================
+ Coverage 87.12% 87.63% +0.52%
==========================================
Files 200 190 -10
Lines 6109 5868 -241
==========================================
- Hits 5322 5142 -180
+ Misses 787 726 -61
|
marcalff
reviewed
Aug 22, 2024
Member
|
This set of changes looks good already. Please tag as ready for review, so this part can be merged. |
marcalff
approved these changes
Aug 25, 2024
Member
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the cleanup.
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Aug 25, 2024
[Code Health] Clang Tidy cleanup, Part 2 (open-telemetry#3038)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2053
Changes
In continuation to Cleanup 1, this changes reduces a lot of clang-tidy warnings and removed some checks that are not relevant.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes