Propagate trace and parent span ids#305
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
+ Coverage 94.55% 94.60% +0.04%
==========================================
Files 146 146
Lines 6610 6633 +23
==========================================
+ Hits 6250 6275 +25
+ Misses 360 358 -2
|
g-easy
reviewed
Aug 28, 2020
Contributor
Author
|
@reyang Ready to merge :) |
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
[BUILD] Error out when building DLL without MSVC (open-telemetry#3438)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the
Spanclass contains aSpanContextinstance, we can propagate trace and parent span ids usingSpanContext. When the tracer creates a newSpan, get theSpanContextof the current span from the runtime context and pass it to theSpanconstructor. In theSpanconstructor, create a newSpanContextand use the parent span context to set the trace and parent span id.I exported to GCP using the OTLP example (

example/otlp) and verified that the trace and parent span ids propagate properly: