Skip to content

Update sample decision name based on spec update#327

Merged
reyang merged 3 commits into
open-telemetry:masterfrom
ThomsonTan:Update_sample_name
Sep 17, 2020
Merged

Update sample decision name based on spec update#327
reyang merged 3 commits into
open-telemetry:masterfrom
ThomsonTan:Update_sample_name

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

Inconsistent naming of sampling decision was updated in OTel trace SDK spec PR, this PR does the renaming to keep conformance with spec.

@ThomsonTan ThomsonTan requested a review from a team September 17, 2020 02:22
Comment thread sdk/src/trace/samplers/parent_or_else.cc
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2020

Codecov Report

Merging #327 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files         148      148           
  Lines        6651     6651           
=======================================
  Hits         6292     6292           
  Misses        359      359           
Impacted Files Coverage Δ
sdk/include/opentelemetry/sdk/trace/sampler.h 100.00% <ø> (ø)
.../opentelemetry/sdk/trace/samplers/parent_or_else.h 100.00% <ø> (ø)
...ude/opentelemetry/sdk/trace/samplers/probability.h 100.00% <ø> (ø)
sdk/test/trace/tracer_test.cc 99.09% <ø> (ø)
...lude/opentelemetry/sdk/trace/samplers/always_off.h 100.00% <100.00%> (ø)
sdk/src/trace/samplers/parent_or_else.cc 100.00% <100.00%> (ø)
sdk/src/trace/samplers/probability.cc 100.00% <100.00%> (ø)
sdk/src/trace/tracer.cc 70.96% <100.00%> (ø)
sdk/test/trace/always_off_sampler_test.cc 100.00% <100.00%> (ø)
sdk/test/trace/parent_or_else_sampler_test.cc 100.00% <100.00%> (ø)
... and 1 more

@reyang reyang merged commit b827d79 into open-telemetry:master Sep 17, 2020
@ThomsonTan ThomsonTan deleted the Update_sample_name branch November 9, 2020 09:06
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
Update ubuntu:24.04 Docker digest to b59d215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants