fix context data structure to support multiple attributes#330
Merged
Conversation
lalitb
changed the title
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 94.60% 94.62% +0.01%
==========================================
Files 148 148
Lines 6651 6655 +4
==========================================
+ Hits 6292 6297 +5
+ Misses 359 358 -1
|
pyohannes
approved these changes
Sep 17, 2020
Contributor
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 17, 2025
[SDK] Use shared_ptr internally for AttributesProcessor to prevent us…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tiny(est) of fixes to prevent crash while creating new context from existing context properties. The reference variable was used to store list head and later to iterate over the context list (at line 46), which eventually crashes. Changed it to non-reference variable, and added test case to validate the scenario.