Skip to content

Remove unnecessary reference to StartSpanOptions#338

Merged
reyang merged 1 commit into
open-telemetry:masterfrom
ThomsonTan:RemoveUnusedRef
Sep 25, 2020
Merged

Remove unnecessary reference to StartSpanOptions#338
reyang merged 1 commit into
open-telemetry:masterfrom
ThomsonTan:RemoveUnusedRef

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

The no-op reference to input parameter options is no longer necessary because it is referenced later in the same function at line 101.

@ThomsonTan ThomsonTan requested a review from a team September 25, 2020 17:19
@ThomsonTan ThomsonTan changed the title Removed unnecessary reference to StartSpanOptions Remove unnecessary reference to StartSpanOptions Sep 25, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 25, 2020

Codecov Report

Merging #338 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files         148      148           
  Lines        6729     6729           
=======================================
  Hits         6373     6373           
  Misses        356      356           
Impacted Files Coverage Δ
sdk/src/trace/span.cc 83.11% <ø> (ø)

@reyang reyang merged commit 813816c into open-telemetry:master Sep 25, 2020
@ThomsonTan ThomsonTan deleted the RemoveUnusedRef branch November 9, 2020 09:06
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…elemetry-collector-0.x

Update otel/opentelemetry-collector Docker tag to v0.128.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants