Skip to content

AddEvent support for Span#343

Merged
reyang merged 6 commits into
open-telemetry:masterfrom
ThomsonTan:SpanAddEvent
Sep 30, 2020
Merged

AddEvent support for Span#343
reyang merged 6 commits into
open-telemetry:masterfrom
ThomsonTan:SpanAddEvent

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

As per the spec, add events for Span to the field of Recordable object.

@ThomsonTan ThomsonTan requested a review from a team September 29, 2020 03:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 29, 2020

Codecov Report

Merging #343 into master will increase coverage by 0.07%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   94.64%   94.71%   +0.07%     
==========================================
  Files         154      154              
  Lines        6813     6847      +34     
==========================================
+ Hits         6448     6485      +37     
+ Misses        365      362       -3     
Impacted Files Coverage Δ
sdk/src/trace/span.cc 88.37% <75.00%> (+5.25%) ⬆️
sdk/test/trace/tracer_test.cc 100.00% <100.00%> (ø)
api/include/opentelemetry/trace/span.h 100.00% <0.00%> (ø)
sdk/include/opentelemetry/sdk/trace/recordable.h 100.00% <0.00%> (ø)

Comment thread sdk/test/trace/tracer_test.cc
@pyohannes
Copy link
Copy Markdown
Contributor

Closes #320.

@pyohannes pyohannes linked an issue Sep 29, 2020 that may be closed by this pull request
@pyohannes pyohannes added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Sep 30, 2020
@reyang reyang merged commit 25a0ea5 into open-telemetry:master Sep 30, 2020
@ThomsonTan ThomsonTan deleted the SpanAddEvent branch November 9, 2020 09:06
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Aug 31, 2025
…ity-harden-runner-2.x

Update step-security/harden-runner action to v2.12.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add functionality to create events on spans

4 participants