Change type of Resize capacity from int to size_t#346
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 154 154
Lines 6847 6847
=======================================
Hits 6485 6485
Misses 362 362
|
pyohannes
approved these changes
Sep 30, 2020
reyang
approved these changes
Sep 30, 2020
6 tasks
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Aug 31, 2025
…el_lib-2.x Update dependency aspect_bazel_lib to v2.19.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameter
new_capacityforRuntimeContext::Resize()should be in typesize_tinstead ofint, to be consistent withsize_.This could cause issue because
size_tcould have larger range thanint(this is the case on Windows 64-bit system which is in LLP64 data model), so convertsize_ttointcould cause data loss.