Skip to content

fix compile time warnings#352

Merged
reyang merged 4 commits into
open-telemetry:masterfrom
lalitb:fix-warnings
Oct 7, 2020
Merged

fix compile time warnings#352
reyang merged 4 commits into
open-telemetry:masterfrom
lalitb:fix-warnings

Conversation

@lalitb
Copy link
Copy Markdown
Member

@lalitb lalitb commented Oct 5, 2020

As indicated in subject, quick fix to eliminate compile time warnings originating from -Wsign-compare and -Wreorder flags.

@lalitb lalitb requested a review from a team October 5, 2020 14:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 5, 2020

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         154      154           
  Lines        6853     6853           
=======================================
  Hits         6491     6491           
  Misses        362      362           
Impacted Files Coverage Δ
api/include/opentelemetry/context/context.h 100.00% <ø> (ø)
...opentelemetry/exporters/ostream/metrics_exporter.h 98.66% <100.00%> (ø)
sdk/src/metrics/meter.cc 88.21% <100.00%> (ø)

Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Oct 5, 2020
@reyang reyang merged commit 7826040 into open-telemetry:master Oct 7, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Aug 31, 2025
…up-buildx-action-3.x

Update docker/setup-buildx-action action to v3.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants