Initial Commit of Logging API#378
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 94.91% 94.97% +0.05%
==========================================
Files 155 162 +7
Lines 6882 6979 +97
==========================================
+ Hits 6532 6628 +96
- Misses 350 351 +1
|
reyang
reviewed
Oct 27, 2020
reyang
reviewed
Oct 27, 2020
reyang
reviewed
Oct 27, 2020
reyang
reviewed
Oct 27, 2020
reyang
reviewed
Oct 27, 2020
reyang
reviewed
Oct 27, 2020
reyang
reviewed
Oct 27, 2020
reyang
reviewed
Oct 27, 2020
ThomsonTan
reviewed
Oct 27, 2020
ThomsonTan
reviewed
Oct 27, 2020
ThomsonTan
reviewed
Oct 27, 2020
| void log(nostd::string_view name = "", | ||
| Severity sev = Severity::kNone, | ||
| const T &attributes = {}) noexcept | ||
| { |
Contributor
There was a problem hiding this comment.
log() could be called without any input parameters, is this needed and useful?
Member
There was a problem hiding this comment.
Good catch, I think we should prevent folks from calling log() without any argument.
ThomsonTan
reviewed
Oct 27, 2020
reyang
reviewed
Oct 27, 2020
reyang
reviewed
Oct 27, 2020
reyang
approved these changes
Oct 27, 2020
Member
reyang
left a comment
reyang
left a comment
There was a problem hiding this comment.
LGTM, there are things not hammered out but no need to block this PR.
maxgolov
reviewed
Oct 27, 2020
maxgolov
reviewed
Oct 27, 2020
ThomsonTan
approved these changes
Oct 27, 2020
This was referenced Nov 4, 2020
This was referenced Dec 1, 2020
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Aug 31, 2025
…eql-action-3.x Update github/codeql-action action to v3.29.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an initial commit of the Logging API for C++ #337. The goal of the Logging API is to only implement the minimum set of features that are required to capture (not send/configure) data from the user. This API closely follows the Log Data Model and Logging specification overview.
This PR adds:
metricsandtracesLogRecord- to be finalized)Future enhancements include:
void debug(...),void trace(...),void info(...), ..., orLogDebug(...),LogTrace(...),LogInfo(...),...)LOG_ERROR,LOG_E,LOG_E_IF, ...)LogRecord(e.g. overloaded constructors)The design doc will be published as part of a future PR.
Suggestions and feedback are appreciated. Further comments are also being collected on RFC #356.
-- cc @MarkSeufert @alolita @reyang @ThomsonTan @maxgolov