script to add versioning info#399
Merged
lalitb merged 14 commits intoopen-telemetry:masterfrom Dec 4, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 175 175
Lines 7591 7591
=======================================
Hits 7194 7194
Misses 397 397 |
pyohannes
reviewed
Nov 20, 2020
jsuereth
approved these changes
Nov 24, 2020
pyohannes
reviewed
Nov 26, 2020
ThomsonTan
reviewed
Nov 30, 2020
ThomsonTan
reviewed
Nov 30, 2020
Co-authored-by: Tom Tan <lilotom@gmail.com>
ThomsonTan
approved these changes
Nov 30, 2020
pyohannes
approved these changes
Dec 3, 2020
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Aug 31, 2025
[SDK] Fixes duration overflow (open-telemetry#3529)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #397
This PR brings script for adding versioning information in
version.ccin sdk. It can be used in following ways:Executing as pre-commit/pre-merge-commit git hooks - It won't be feasible to enforce this for every developer, unless we checkin it at
.git\hooks\pre-commit. Not sure if this is good practice to enforce developers to run scripts locally. As of now developers need to create this link manually first time after fork.This can be added as github server-side webooks, which would need more management as separate server need to be created to listen to github events. Ignoring this option for now.
It is definitively required to run this script as part of release process, and this has been documented in RELEASING.md.
If it is not important to checkin the modified
version.ccfile in repo, and only add it as part of release asset, the process can be automated through separate Github Release workflow which first runs this script, create release and subsequently upload release asset (https://github.com/actions/upload-release-asset). This way, only created releases will have the correct build information, and not the github repo, and we can automate release creation through github action. Earlier this year, github announced new feature to manually trigger github workflow from action tab in github UI (https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/) , which can be used to manually trigger Release creation from UI.