Add batch log processor implementation with test coverage#434
Merged
lalitb merged 16 commits intoopen-telemetry:masterfrom Dec 22, 2020
Merged
Add batch log processor implementation with test coverage#434lalitb merged 16 commits intoopen-telemetry:masterfrom
lalitb merged 16 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
==========================================
+ Coverage 94.37% 94.43% +0.06%
==========================================
Files 185 187 +2
Lines 8047 8234 +187
==========================================
+ Hits 7594 7776 +182
- Misses 453 458 +5
|
lalitb
reviewed
Dec 10, 2020
Member
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM in general. Few minor changes would be needed in this PR ( as mentioned in comments) once Recordable interface PR is reviewed and merged. As I understand, @xukaren is working on that PR. We can hold this PR for merging till then.
maxgolov
reviewed
Dec 11, 2020
maxgolov
reviewed
Dec 11, 2020
kxyr
force-pushed
the
logs-sdk3
branch
2 times, most recently
from
5ba22ce to
f642a60
Compare
kxyr
force-pushed
the
logs-sdk3
branch
2 times, most recently
from
a55d098 to
13bc179
Compare
added 2 commits
December 15, 2020 11:45
Replace while loop with cv.wait with predicate Remove while loop around cv.notify Replace operator= with .store() for clarity
jsuereth
requested changes
Dec 16, 2020
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
I still think the concurrency portions of this may need some help.
Given the use of locks + condition for the core of this class, may make sense to just use a real lock/mutex instead of Atomics for now.
ThomsonTan
reviewed
Dec 17, 2020
Contributor
Author
ThomsonTan
reviewed
Dec 18, 2020
Contributor
Author
|
I have reverted this log processor to the same one as the batch span processor. This way there won't be any concurrency issues if this PR is merged. |
jsuereth
approved these changes
Dec 19, 2020
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
I think keeping this the same as the Trace batch processor (for now) is definitely the right call. Threading logic looks good.
ThomsonTan
reviewed
Dec 20, 2020
ThomsonTan
approved these changes
Dec 20, 2020
added 3 commits
December 20, 2020 16:31
maxgolov
reviewed
Dec 21, 2020
maxgolov
reviewed
Dec 21, 2020
maxgolov
approved these changes
Dec 21, 2020
Contributor
|
Logged a separate issue to make this code readable, and/or avoiding the while looks on waiting for variable update: |
maxgolov
added
the
pr:please-merge
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 22, 2020
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 22, 2020
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Mar 6, 2026
…and-patch-dependencies Update dependency rules_go to v0.56.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a batch log processor for the Logging Prototype, based off the batch span processor, and following the simple log processor. The batch log processor has a main thread that is responsible for batching the
LogRecords, and a worker thread that sends these records to an exporter. Note:std::cerrmessages are included here as a placeholder before error diagnostics is available.cc @MarkSeufert @alolita