Skip to content

Http client factory#445

Merged
lalitb merged 15 commits into
open-telemetry:masterfrom
lalitb:http-client-factory
Jan 9, 2021
Merged

Http client factory#445
lalitb merged 15 commits into
open-telemetry:masterfrom
lalitb:http-client-factory

Conversation

@lalitb
Copy link
Copy Markdown
Member

@lalitb lalitb commented Dec 14, 2020 •
edited
Loading

A http client factory interface to select the correct http client implementation based on availability.

@lalitb lalitb requested a review from a team December 14, 2020 08:25
ThomsonTan
ThomsonTan reviewed Dec 14, 2020
View reviewed changes
Comment thread ext/include/opentelemetry/ext/http/client/http_client_factory.h Outdated
ThomsonTan
ThomsonTan reviewed Dec 14, 2020
View reviewed changes
Comment thread ext/include/opentelemetry/ext/http/client/http_client_factory.h Outdated
ThomsonTan
ThomsonTan reviewed Dec 14, 2020
View reviewed changes
Comment thread ext/test/http/CMakeLists.txt
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2020 •
edited
Loading

Codecov Report

Merging #445 (865e54b) into master (c8db847) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   94.47%   94.46%   -0.01%     
==========================================
  Files         188      189       +1     
  Lines        8382     8388       +6     
==========================================
+ Hits         7919     7924       +5     
- Misses        463      464       +1
Impacted Files Coverage Δ
...t/src/http/client/curl/http_client_factory_curl.cc 100.00% <100.00%> (ø)
ext/test/http/curl_http_test.cc 94.01% <100.00%> (+0.10%) ⬆️
sdk/src/logs/batch_log_processor.cc 93.82% <0.00%> (-1.24%) ⬇️
sdk/test/common/circular_buffer_test.cc 98.97% <0.00%> (-1.03%) ⬇️
sdk/test/metrics/counter_aggregator_test.cc 100.00% <0.00%> (+1.78%) ⬆️

@lalitb lalitb mentioned this pull request Dec 14, 2020
Closed
jsuereth
jsuereth reviewed Dec 14, 2020
View reviewed changes
Comment thread ext/include/opentelemetry/ext/http/client/http_client_factory.h Outdated
@lalitb lalitb requested a review from maxgolov December 18, 2020 06:07
@lalitb lalitb mentioned this pull request Dec 18, 2020
Merged
@lalitb lalitb requested a review from jsuereth December 21, 2020 18:53
maxgolov
maxgolov reviewed Dec 31, 2020
View reviewed changes
Comment thread ext/include/opentelemetry/ext/http/client/http_client_factory.h Outdated
@lalitb
Copy link
Copy Markdown
Member Author

lalitb commented Jan 6, 2021

@maxgolov @jsuereth Thanks for reviewing it. Please let me know if there are any further comments, or else it is good for merge ?

maxgolov
maxgolov reviewed Jan 7, 2021
View reviewed changes
Comment thread ext/include/opentelemetry/ext/http/client/http_client_factory.h Outdated
maxgolov
maxgolov reviewed Jan 7, 2021
View reviewed changes
Comment thread ext/include/opentelemetry/ext/http/client/http_client_factory.h Outdated
maxgolov
maxgolov reviewed Jan 7, 2021
View reviewed changes
Comment thread ext/test/http/curl_http_test.cc
maxgolov
maxgolov reviewed Jan 7, 2021
View reviewed changes
Comment thread ext/test/http/curl_http_test.cc
maxgolov
maxgolov reviewed Jan 7, 2021
View reviewed changes
Comment thread ext/test/http/curl_http_test.cc
@lalitb lalitb merged commit c78be17 into open-telemetry:master Jan 9, 2021
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Mar 6, 2026
@malkia
Merge pull request open-telemetry#445 from malkia/renovate/all-minor-…
11f8303 
…and-patch-dependencies

Update dependency boringssl to v0.20250807.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth

+2 more reviewers

@pyohannes pyohannes pyohannes approved these changes

@maxgolov maxgolov maxgolov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lalitb @jsuereth @ThomsonTan @pyohannes @maxgolov