Add spellcheck#54
Closed
reyang wants to merge 3 commits into
Closed
Conversation
reyang
requested review from
g-easy,
jmacd,
maxgolov,
rnburn and
tigrannajaryan
as code owners
g-easy
reviewed
Mar 19, 2020
g-easy
reviewed
Mar 23, 2020
|
|
||
| - name: install misspell | ||
| run: | | ||
| curl -L -o ./install-misspell.sh https://git.io/misspell |
Contributor
There was a problem hiding this comment.
Is there a less risky way to install this than curl http://redirection-service | bash ? :)
e.g. For autoformatting we "go get" a thing.
Member
There was a problem hiding this comment.
There is option using
$ go get -u github.com/client9/misspell/cmd/misspell
but don't think golang is part of default ubuntu-latest installation.
lalitb
approved these changes
Jun 25, 2020
|
|
||
| - name: install misspell | ||
| run: | | ||
| curl -L -o ./install-misspell.sh https://git.io/misspell |
Member
There was a problem hiding this comment.
There is option using
$ go get -u github.com/client9/misspell/cmd/misspell
but don't think golang is part of default ubuntu-latest installation.
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jul 27, 2024
[EXPORTER] Fix references in AttributeValueVisitor (open-telemetry#2985)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open question: do we think GitHub Actions are okay or we want to restrict to Circle CI?