Skip to content

Set default endpoint for OTLP exporters#1464

Merged
bogdandrutu merged 3 commits intoopen-telemetry:masterfrom
trask:otlp-default-endpoint
Jul 25, 2020
Merged

Set default endpoint for OTLP exporters#1464
bogdandrutu merged 3 commits intoopen-telemetry:masterfrom
trask:otlp-default-endpoint

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Jul 24, 2020

I also went ahead and sync'd up the configuration settings between OTLP span and metrics exporters.

A common base class might be nice for those two builders in the future.

Closes #1463

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 25, 2020

Codecov Report

Merging #1464 into master will decrease coverage by 0.48%.
The diff coverage is 15.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1464      +/-   ##
============================================
- Coverage     87.35%   86.86%   -0.49%     
  Complexity     1328     1328              
============================================
  Files           162      162              
  Lines          5062     5094      +32     
  Branches        460      469       +9     
============================================
+ Hits           4422     4425       +3     
- Misses          472      496      +24     
- Partials        168      173       +5     
Impacted Files Coverage Δ Complexity Δ
...lemetry/exporters/otlp/OtlpGrpcMetricExporter.java 52.23% <12.90%> (-33.88%) 6.00 <0.00> (ø)
...telemetry/exporters/otlp/OtlpGrpcSpanExporter.java 70.14% <50.00%> (+0.45%) 5.00 <0.00> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 94.59% <0.00%> (-1.36%) 8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab95a19...d3b1609. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 0b88582 into open-telemetry:master Jul 25, 2020
@trask trask deleted the otlp-default-endpoint branch March 5, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set default endpoint for OTLP span and metric exporters to "localhost:55680"

3 participants