Set default endpoint for OTLP exporters#1464
Merged
bogdandrutu merged 3 commits intoopen-telemetry:masterfrom Jul 25, 2020
Merged
Set default endpoint for OTLP exporters#1464bogdandrutu merged 3 commits intoopen-telemetry:masterfrom
bogdandrutu merged 3 commits intoopen-telemetry:masterfrom
Conversation
anuraaga
approved these changes
Jul 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
============================================
- Coverage 87.35% 86.86% -0.49%
Complexity 1328 1328
============================================
Files 162 162
Lines 5062 5094 +32
Branches 460 469 +9
============================================
+ Hits 4422 4425 +3
- Misses 472 496 +24
- Partials 168 173 +5
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Jul 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also went ahead and sync'd up the configuration settings between OTLP span and metrics exporters.
A common base class might be nice for those two builders in the future.
Closes #1463