Move the TraceFlags isSampled boolean into the SpanContext#1628
Merged
jkwatson merged 6 commits intoopen-telemetry:masterfrom Sep 14, 2020
Merged
Move the TraceFlags isSampled boolean into the SpanContext#1628jkwatson merged 6 commits intoopen-telemetry:masterfrom
jkwatson merged 6 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
============================================
- Coverage 86.61% 86.55% -0.06%
+ Complexity 1408 1397 -11
============================================
Files 163 163
Lines 5529 5497 -32
Branches 553 552 -1
============================================
- Hits 4789 4758 -31
+ Misses 544 543 -1
Partials 196 196 Continue to review full report at Codecov.
|
anuraaga
reviewed
Sep 9, 2020
...ropagators/src/main/java/io/opentelemetry/extensions/trace/propagation/JaegerPropagator.java
Outdated
Show resolved
Hide resolved
anuraaga
approved these changes
Sep 9, 2020
...opagators/src/main/java/io/opentelemetry/extensions/trace/propagation/AwsXRayPropagator.java
Outdated
Show resolved
Hide resolved
…tensions/trace/propagation/AwsXRayPropagator.java Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Contributor
Author
|
@bogdandrutu @carlosalberto this is an API change. If you're interested, please review! |
bogdandrutu
reviewed
Sep 10, 2020
carlosalberto
approved these changes
Sep 10, 2020
Contributor
|
Overall LGTM, thanks for this PR! |
Contributor
|
LGTM makes sense to discuss byte vs boolean separately. |
thisthat
approved these changes
Sep 14, 2020
bogdandrutu
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1603