Merged
Conversation
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay,
thisthat and
tylerbenson
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1634 +/- ##
============================================
+ Coverage 86.65% 86.71% +0.06%
Complexity 1409 1409
============================================
Files 163 163
Lines 5529 5557 +28
Branches 553 553
============================================
+ Hits 4791 4819 +28
Misses 542 542
Partials 196 196
Continue to review full report at Codecov.
|
Oberon00
reviewed
Sep 11, 2020
| public static final StringAttributeSetter FAAS_INVOKED_REGION = | ||
| StringAttributeSetter.create("faas.invoked_region"); | ||
|
|
||
| // faas.trigger == datasource |
Member
There was a problem hiding this comment.
Should this comment be added to the Javadoc of the respective attributes somehow?
iNikem
approved these changes
Sep 11, 2020
bogdandrutu
approved these changes
Sep 11, 2020
Contributor
|
Thanks! I bet you did this just so I would have to update #1631 , didn't you? ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.