Add Context arg to SpanProcessor.OnStart.#1792
Add Context arg to SpanProcessor.OnStart.#1792anuraaga merged 1 commit intoopen-telemetry:masterfrom
Conversation
| return; | ||
| } | ||
| enqueue(EventType.ON_START, span, null); | ||
| enqueue(EventType.ON_START, new AbstractMap.SimpleImmutableEntry<>(span, parentContext), null); |
There was a problem hiding this comment.
This seems a bit dirty, so if someone can suggest a better solution that would be good.
There was a problem hiding this comment.
I think it's fine for now, although agree it's ugly. I would like to revisit the way the disruptor messages are built at some point, since I ran into difficulties when trying to work with it a few months ago, as well. I think the best answer might be to create a Tuple to hold the message data, or maybe split the message types so they can be more easily customized.
Codecov Report
@@ Coverage Diff @@
## master #1792 +/- ##
============================================
+ Coverage 85.94% 85.96% +0.02%
Complexity 1379 1379
============================================
Files 166 166
Lines 5307 5308 +1
Branches 549 549
============================================
+ Hits 4561 4563 +2
+ Misses 551 550 -1
Partials 195 195
Continue to review full report at Codecov.
|
Fixes #1785.