Initial list of best practices to follow in our project#1925
Merged
bogdandrutu merged 3 commits intoopen-telemetry:masterfrom Oct 31, 2020
Merged
Initial list of best practices to follow in our project#1925bogdandrutu merged 3 commits intoopen-telemetry:masterfrom
bogdandrutu merged 3 commits intoopen-telemetry:masterfrom
Conversation
bogdandrutu
requested review from
anuraaga,
arminru,
carlosalberto,
jkwatson,
pavolloffay,
thisthat and
tylerbenson
as code owners
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
bestpractices
branch
from
9b8b106 to
9f36bb5
Compare
jkwatson
reviewed
Oct 29, 2020
Co-authored-by: John Watson <jkwatson@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1925 +/- ##
============================================
- Coverage 86.63% 86.61% -0.02%
- Complexity 1500 1502 +2
============================================
Files 184 184
Lines 5663 5664 +1
Branches 582 582
============================================
Hits 4906 4906
Misses 551 551
- Partials 206 207 +1
Continue to review full report at Codecov.
|
anuraaga
approved these changes
Oct 30, 2020
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
carlosalberto
approved these changes
Oct 30, 2020
tylerbenson
approved these changes
Oct 30, 2020
Oberon00
reviewed
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com