Skip to content

Rename package resource to resources.#366

Merged
bogdandrutu merged 2 commits intoopen-telemetry:masterfrom
songy23:rename-resources
May 31, 2019
Merged

Rename package resource to resources.#366
bogdandrutu merged 2 commits intoopen-telemetry:masterfrom
songy23:rename-resources

Conversation

@songy23
Copy link
Copy Markdown
Member

@songy23 songy23 commented May 31, 2019

Fixes #259.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 31, 2019

Codecov Report

Merging #366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #366   +/-   ##
=========================================
  Coverage     63.95%   63.95%           
  Complexity      338      338           
=========================================
  Files            57       57           
  Lines          1293     1293           
  Branches        118      118           
=========================================
  Hits            827      827           
  Misses          423      423           
  Partials         43       43
Impacted Files Coverage Δ Complexity Δ
...main/java/io/opentelemetry/resources/Resource.java 85.71% <ø> (ø) 10 <0> (?)
...in/java/io/opentelemetry/metrics/DefaultMeter.java 54.02% <ø> (ø) 12 <0> (ø) ⬇️
...ain/java/io/opentelemetry/trace/DefaultTracer.java 68.29% <ø> (ø) 6 <0> (ø) ⬇️
...ain/java/io/opentelemetry/sdk/trace/TracerSdk.java 40% <ø> (ø) 5 <0> (ø) ⬇️
...src/main/java/io/opentelemetry/trace/SpanData.java 13.79% <ø> (ø) 0 <0> (ø) ⬇️
...io/opentelemetry/sdk/resources/EnvVarResource.java 0% <ø> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cadf603...84a6213. Read the comment docs.

@songy23 songy23 force-pushed the rename-resources branch from e79a4cb to f07df28 Compare May 31, 2019 16:46
@bogdandrutu
Copy link
Copy Markdown
Member

Fix the build?

@songy23
Copy link
Copy Markdown
Member Author

songy23 commented May 31, 2019

Build fixed, PTAL.

@bogdandrutu bogdandrutu merged commit 0a0a27e into open-telemetry:master May 31, 2019
@songy23 songy23 deleted the rename-resources branch June 4, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: Package names consistency

3 participants